Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Parsing the query string on location change #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adregan
Copy link
Contributor

@adregan adregan commented Jul 11, 2017

This PR is intended to fix #211.

Issue:

When navigating via the back button to a route which contains a query string, you will not receive a query object (parsed search string) in the payload.

Changes:

  • parses the search string in a similar manner as the ROUTER_POP action.

There was an issue when using the back button to navigate to a route
that had a query string in it. It would be available in the search
field, but it was not available as a query object.

This commit simply performs the same parsing of the query string that
the ROUTER_POP state receives.
@codecov
Copy link

codecov bot commented Jul 11, 2017

Codecov Report

Merging #212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files          19       19           
  Lines         253      253           
=======================================
  Hits          249      249           
  Misses          4        4
Impacted Files Coverage Δ
src/enhancer.js 94.11% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa3297...b29ba43. Read the comment docs.

@jahed
Copy link

jahed commented Aug 26, 2017

@tptee Are there any plans to merge this in? This is a pretty major bug.

Edit: I've tried this change out and it hasn't solved the problem for me. I'll keep looking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query object is not passed when using the back button
2 participants